Merge pull request conda-forge#313 from mbargull-feedstocks/posix-act…

…ivation-scripts Use POSIX scripts for de-/activation scripts
isuruf · Jun 27, 2024 · 8fbc98a · 8fbc98a
1 parent af8f3eb
commit 8fbc98a
Show file tree

Hide file tree

Showing 6 changed files with 53 additions and 31 deletions.
diff --git a/recipe/activate-cross-r-base.sh b/recipe/activate-cross-r-base.sh
@@ -1,14 +1,17 @@
-if [[ "$CONDA_BUILD" == "" ]]; then
+# shellcheck shell=sh
+
+if [ -z "${CONDA_BUILD:+x}" ]; then
   echo "This package can only be used in conda-build"
   exit 1
 fi
 
-if [[ "$CONDA_BUILD_STATE" != "TEST" && "$build_platform" != "$target_platform" ]]; then
-  export R=$BUILD_PREFIX/bin/R
-  export R_ARGS="--library=$PREFIX/lib/R/library --no-test-load"
-  echo "R_HOME=$PREFIX/lib/R"     > $BUILD_PREFIX/lib/R/etc/Makeconf
-  cat $PREFIX/lib/R/etc/Makeconf >> $BUILD_PREFIX/lib/R/etc/Makeconf
-  if [[ -d $BUILD_PREFIX/lib/R/library ]]; then
-    rsync -a -I $BUILD_PREFIX/lib/R/library/ $PREFIX/lib/R/library/
+# shellcheck disable=SC2154  # assume variables are set at this point
+if [ "${CONDA_BUILD_STATE-}" != "TEST" ] && [ "${build_platform}" != "${target_platform}" ]; then
+  export R="${BUILD_PREFIX}/bin/R"
+  export R_ARGS="--library=${PREFIX}/lib/R/library --no-test-load"
+  echo "R_HOME=${PREFIX}/lib/R"       > "${BUILD_PREFIX}/lib/R/etc/Makeconf"
+  cat "${PREFIX}/lib/R/etc/Makeconf" >> "${BUILD_PREFIX}/lib/R/etc/Makeconf"
+  if [ -d "${BUILD_PREFIX}/lib/R/library" ]; then
+    rsync -a -I "${BUILD_PREFIX}/lib/R/library/" "${PREFIX}/lib/R/library/"
   fi
 fi
diff --git a/recipe/activate-r-base.sh b/recipe/activate-r-base.sh
@@ -1,8 +1,10 @@
-#!/usr/bin/env sh
+# shellcheck shell=sh
+
 R CMD javareconf > /dev/null 2>&1 || true
 
 # store existing RSTUDIO_WHICH_R
-if [[ ! -z ${RSTUDIO_WHICH_R+x} ]]; then
-  export RSTUDIO_WHICH_R_PREV="$RSTUDIO_WHICH_R"
+if [ -n "${RSTUDIO_WHICH_R+x}" ]; then
+  export RSTUDIO_WHICH_R_PREV="${RSTUDIO_WHICH_R}"
 fi
-export RSTUDIO_WHICH_R="$CONDA_PREFIX/bin/R"
+# shellcheck disable=SC2154  # CONDA_PREFIX is always set in this context
+export RSTUDIO_WHICH_R="${CONDA_PREFIX}/bin/R"
diff --git a/recipe/build-r-base.sh b/recipe/build-r-base.sh
@@ -455,22 +455,30 @@ Darwin() {
     popd
 }
 
-if [[ $target_platform =~ .*osx.* ]]; then
-  Darwin
-  mkdir -p ${PREFIX}/etc/conda/activate.d
-  cp "${RECIPE_DIR}"/activate-${PKG_NAME}.sh ${PREFIX}/etc/conda/activate.d/activate-${PKG_NAME}.sh
-  mkdir -p ${PREFIX}/etc/conda/deactivate.d
-  cp "${RECIPE_DIR}"/deactivate-${PKG_NAME}.sh ${PREFIX}/etc/conda/deactivate.d/deactivate-${PKG_NAME}.sh
-elif [[ $target_platform =~ .*linux.* ]]; then
-  Linux
-  mkdir -p ${PREFIX}/etc/conda/activate.d
-  cp "${RECIPE_DIR}"/activate-${PKG_NAME}.sh ${PREFIX}/etc/conda/activate.d/activate-${PKG_NAME}.sh
-  mkdir -p ${PREFIX}/etc/conda/deactivate.d
-  cp "${RECIPE_DIR}"/deactivate-${PKG_NAME}.sh ${PREFIX}/etc/conda/deactivate.d/deactivate-${PKG_NAME}.sh
-elif [[ $target_platform =~ .*win.* ]]; then
-  # Mingw_w64_autotools
-  Mingw_w64_makefiles
-fi
+case "${target_platform}" in
+  osx-* )
+    Darwin
+    ;;
+  linux-* )
+    Linux
+    ;;
+  win-* )
+    # Mingw_w64_autotools
+    Mingw_w64_makefiles
+    ;;
+esac
+case "${target_platform}" in
+  osx-* | linux-* )
+    for action in activate deactivate; do
+      if [[ "${build_platform}" != linux-ppc64le ]] ; then
+        shellcheck --shell=sh --severity=style --enable=check-unassigned-uppercase \
+          "${RECIPE_DIR}/${action}-${PKG_NAME}.sh"
+      fi
+      mkdir -p "${PREFIX}/etc/conda/${action}.d"
+      cp "${RECIPE_DIR}/${action}-${PKG_NAME}.sh" "${PREFIX}/etc/conda/${action}.d/"
+    done
+    ;;
+esac
 
 if [[ "$CONDA_BUILD_CROSS_COMPILATION" == "1" ]]; then
   pushd $BUILD_PREFIX/lib/R

diff --git a/recipe/deactivate-r-base.sh b/recipe/deactivate-r-base.sh
@@ -1,8 +1,8 @@
-#!/usr/bin/env sh
+# shellcheck shell=sh
 
 # restore pre-existing RSTUDIO_WHICH_R
-if [[ ! -z ${RSTUDIO_WHICH_R_PREV+x} ]]; then
-  export RSTUDIO_WHICH_R="$RSTUDIO_WHICH_R_PREV"
+if [ -n "${RSTUDIO_WHICH_R_PREV+x}" ]; then
+  export RSTUDIO_WHICH_R="${RSTUDIO_WHICH_R_PREV}"
   unset RSTUDIO_WHICH_R_PREV
 else
   unset RSTUDIO_WHICH_R

diff --git a/recipe/install-cross-activate.sh b/recipe/install-cross-activate.sh
@@ -1,2 +1,6 @@
+if [[ "${build_platform}" != linux-ppc64le ]] ; then
+  shellcheck --shell=sh --severity=style --enable=check-unassigned-uppercase \
+    "${RECIPE_DIR}/activate-cross-r-base.sh"
+fi
 mkdir -p  $PREFIX/etc/conda/activate.d/
 cp $RECIPE_DIR/activate-cross-r-base.sh $PREFIX/etc/conda/activate.d/activate-cross-r-base.sh
diff --git a/recipe/meta.yaml b/recipe/meta.yaml
@@ -85,6 +85,8 @@ outputs:
         - m2-automake-wrapper                # [win]
         - automake                           # [not win]
         - make                               # [not win]
+        # shellcheck is used to check activation scripts; it is not yet built for linux-ppc64le.
+        - shellcheck                         # [unix and build_platform != "linux-ppc64le"]
         - libcurl                            # [not win]
         - readline                            # [build_platform != target_platform]
         - libcurl                             # [build_platform != target_platform]
@@ -192,6 +194,9 @@ outputs:
       skip: true  # [win]
     script: install-cross-activate.sh
     requirements:
+      build:
+        # shellcheck is used to check activation scripts; it is not yet built for linux-ppc64le.
+        - shellcheck  # [build_platform != "linux-ppc64le"]
       run:
         - {{ pin_subpackage("r-base", exact=True) }}
         - rsync