Sign up error handling #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lvyshnevska
approved these changes
Oct 9, 2023
| console.log(process.env.REACT_APP_BASE_API_URL); | ||
| data: dataToSend, | ||
| }) | ||
| .then() |
There was a problem hiding this comment.
No need to leave empty then here
There was a problem hiding this comment.
But should the user somehow be informed that registration is successfull?
There was a problem hiding this comment.
It will be used to trigger notification modal #262 as far as I know. That's why I decided to leave it even though it's empty.
popovycholeg
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the #124 task [Sign Up: 400 email exists]
2 first commits are duplicated from #255 PR since they are fixing eslint errors after merge conflicts in #248
after #255 is merged, only 1 file will have changes:
SignUpFormContent, so please have look only at it[upd: 09/10 now is up to date state]