#789 alternative text for images format #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanZhylavy
reviewed
Sep 19, 2024
| @@ -9,7 +9,7 @@ const WarnUnsavedDataModal = ({ onCancel, onConfirm }) => { | |||
| Збереження введених даних | |||
| </p> | |||
| <button onClick={onCancel} className={classes['modal-header--close-icon']}> | |||
| <img src={`${process.env.REACT_APP_PUBLIC_URL}/svg/cross-btn.svg`} /> | |||
| <img src={`${process.env.REACT_APP_PUBLIC_URL}/svg/cross-btn.svg`} alt="Cross btn" /> | |||
There was a problem hiding this comment.
Consider something like "Cancel button" here, becouse "Cross btn" may be confusing for screenreader users.
YanZhylavy
reviewed
Sep 19, 2024
| @@ -8,12 +8,12 @@ const MainPartners = () => { | |||
| <div className="partners-section__navi-icons"> | |||
| <div className="partners-section__navi-icon"> | |||
| <div className="partners-section__icon"> | |||
| <img src="/svg/icon-left.svg" alt="" /> | |||
| <img src="/svg/icon-left.svg" alt="Left" /> | |||
There was a problem hiding this comment.
The content of the alt attribute is literally what will be read by a screen reader, for example, if the user can not see. I would use more descriptive text.
Lvyshnevska
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formated title and styles css