823 admin frontend view users list with sorting functionality #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrewakiv
requested review from
popovycholeg,
AlexanderSychev2005 and
Lvyshnevska
Comment on lines
41
to
45
| const newOrder = sortInfo.order === 'ascend' | ||
| ? 'descend' | ||
| : sortInfo.order === 'descend' | ||
| ? null | ||
| : 'ascend'; |
There was a problem hiding this comment.
nit: Tripple ternary is a bad code smell. Consider using if/else.
popovycholeg
approved these changes
Oct 31, 2024
…into 823-Admin-Frontend-View-Users-List-with-Sorting-Functionality
AlexanderSychev2005
approved these changes
Nov 2, 2024
Lvyshnevska
approved these changes
Nov 4, 2024
Andrewakiv
deleted the
823-Admin-Frontend-View-Users-List-with-Sorting-Functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a user management table with sorting, pagination, and status filtering functionality. The table should display user information (name, email, company, status, registration date), allow sorting by columns, filter by status