fixed code smells

ita-social-projects · Dec 14, 2023 · 6f36ab0 · 6f36ab0
1 parent 97cd968
commit 6f36ab0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/service-api/src/main/java/greencity/constant/EmailNotificationMessagesConstants.java b/service-api/src/main/java/greencity/constant/EmailNotificationMessagesConstants.java
@@ -1,6 +1,8 @@
 package greencity.constant;
 
 public final class EmailNotificationMessagesConstants {
+
+    private EmailNotificationMessagesConstants(){}
     public static final String ECONEWS_CREATION_SUBJECT = "You have created eco news";
     public static final String ECONEWS_CREATION_MESSAGE = "you successfully created eco news ";
     public static final String ECONEWS_LIKE_SUBJECT = "Your news received a like";

diff --git a/service/src/main/java/greencity/service/EventServiceImpl.java b/service/src/main/java/greencity/service/EventServiceImpl.java
@@ -177,15 +177,15 @@ public void delete(Long eventId, String email) {
             emailThreadPool.submit(() -> {
                 try {
                     RequestContextHolder.setRequestAttributes(originalRequestAttributes);
-                    attendersEmails.forEach(attenderEmail -> {
+                    attendersEmails.forEach(attenderEmail ->
                         notificationService.sendEmailNotification(
                             GeneralEmailMessage.builder()
                                 .email(attenderEmail)
                                 .subject(EmailNotificationMessagesConstants.EVENT_CANCELED_SUBJECT)
                                 .message(
                                     EmailNotificationMessagesConstants.EVENT_CANCELED_MESSAGE + toDelete.getTitle())
-                                .build());
-                    });
+                                .build())
+                    );
                 } finally {
                     RequestContextHolder.resetRequestAttributes();
                 }
@@ -490,14 +490,14 @@ public EventDto update(UpdateEventDto eventDto, String email, MultipartFile[] im
         emailThreadPool.submit(() -> {
             try {
                 RequestContextHolder.setRequestAttributes(originalRequestAttributes);
-                attendersEmails.forEach(attenderEmail -> {
+                attendersEmails.forEach(attenderEmail ->
                     notificationService.sendEmailNotification(
                         GeneralEmailMessage.builder()
                             .email(attenderEmail)
                             .subject(EmailNotificationMessagesConstants.EVENT_UPDATED_SUBJECT)
                             .message(EmailNotificationMessagesConstants.EVENT_UPDATED_MESSAGE + toUpdate.getTitle())
-                            .build());
-                });
+                            .build())
+                );
             } finally {
                 RequestContextHolder.resetRequestAttributes();
             }