Commit with removed code smell

ita-social-projects · Jan 15, 2024 · a361c64 · a361c64
1 parent 9569522
commit a361c64
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/service/src/test/java/greencity/service/MultipartFileImplTest.java b/service/src/test/java/greencity/service/MultipartFileImplTest.java
@@ -15,7 +15,7 @@
 @ExtendWith(SpringExtension.class)
 class MultipartFileImplTest {
     @Test
-    public void testMultipartFileMethods() throws IOException {
+    void testMultipartFileMethods() throws IOException {
         String name = "file";
         String originalFilename = "test.txt";
         String contentType = "text/plain";

diff --git a/service/src/test/java/greencity/service/SocialNetworkImageServiceImplTest.java b/service/src/test/java/greencity/service/SocialNetworkImageServiceImplTest.java
@@ -4,7 +4,7 @@
 import greencity.entity.SocialNetworkImage;
 import greencity.repository.SocialNetworkImageRepo;
 import java.net.URI;
-import java.net.URL;
+import java.nio.file.Paths;
 import java.util.Optional;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -20,18 +20,16 @@
 
 @ExtendWith(MockitoExtension.class)
 class SocialNetworkImageServiceImplTest {
-
     @Mock
     SocialNetworkImageRepo socialNetworkImageRepo;
     @Mock
     ModelMapper modelMapper;
     @InjectMocks
     SocialNetworkImageServiceImpl socialNetworkImageService;
-    private static final String TEST_URL = "http://example.com";
 
     @Test
-    void getSocialNetworkImageByUrl() throws Exception {
-        URL checkUrl = new URL("HTTP://");
+    void getSocialNetworkImageByUrl() {
+        URI checkUrl = Paths.get("HTTP://").toUri();
         SocialNetworkImageVO socialNetworkImageVO = new SocialNetworkImageVO();
         socialNetworkImageVO.setId(1L);
         socialNetworkImageVO.setHostPath(checkUrl.getHost());
@@ -50,21 +48,21 @@ void getSocialNetworkImageByUrl() throws Exception {
 
     @Test
     void getSocialNetworkImageByUrlBadRequest() throws Exception {
-        URI checkUrl = new URI(TEST_URL);
-
+        URI checkUrl = new URI("https://example.com");
         SocialNetworkImageVO socialNetworkImageVO = new SocialNetworkImageVO();
         socialNetworkImageVO.setId(1L);
         socialNetworkImageVO.setHostPath(checkUrl.getHost());
         socialNetworkImageVO.setImagePath(checkUrl.getPath());
 
         when(socialNetworkImageRepo.findByHostPath(checkUrl.getHost())).thenReturn(null);
 
-        assertThrows(RuntimeException.class, () -> socialNetworkImageService.getSocialNetworkImageByUrl(TEST_URL));
+        assertThrows(RuntimeException.class,
+            () -> socialNetworkImageService.getSocialNetworkImageByUrl(checkUrl.toString()));
     }
 
     @Test
-    void findByHostPath() throws Exception {
-        URI checkUrl = new URI("HTTP://example.com/");
+    void findByHostPath() {
+        URI checkUrl = Paths.get("HTTP://example.com/").toUri();
         SocialNetworkImageVO socialNetworkImageVO = new SocialNetworkImageVO();
         socialNetworkImageVO.setId(1L);
         socialNetworkImageVO.setHostPath(checkUrl.getHost());