generated from ita-social-projects/DevTemplate
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1020, Additions to the Calculator #1025
Open
DanielVajnagi
wants to merge
9
commits into
develop
Choose a base branch
from
1020-additions-to-the-calculator
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1025 +/- ##
========================================
Coverage 98.71% 98.71%
========================================
Files 71 71
Lines 1011 1011
========================================
Hits 998 998
Misses 13 13 ☔ View full report in Codecov by Sentry. |
loqimean
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not Final version, still requires text from customer
Code reviewers
Second Level Review
Summary of issue
Adding new requirements to the calculator
Summary of change
Change name to "Menstrual calculator" "Mенструальний калькулятор"
The age of start of menopause must be indicated by default ( gray colour, inside the block), it can be changed by user
Next to the menopause block, there is an information button, when user clicks, the text must be displayed
Instead of "days", it should be "mainly 21-35 days" "переважно 21-35 днів"
Between these two blocks, there is another block with pictures of reusable products
ZeroWaste.-.Google.Chrome.2025-02-14.15-16-14.mp4
CHECK LIST