Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1020, Additions to the Calculator #1025

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

DanielVajnagi
Copy link
Contributor

@DanielVajnagi DanielVajnagi commented Feb 13, 2025

Not Final version, still requires text from customer

Code reviewers

Second Level Review

Summary of issue

Adding new requirements to the calculator

Summary of change

Change name to "Menstrual calculator" "Mенструальний калькулятор"

The age of start of menopause must be indicated by default ( gray colour, inside the block), it can be changed by user

Next to the menopause block, there is an information button, when user clicks, the text must be displayed

Instead of "days", it should be "mainly 21-35 days" "переважно 21-35 днів"
Between these two blocks, there is another block with pictures of reusable products

ZeroWaste.-.Google.Chrome.2025-02-14.15-16-14.mp4

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@DanielVajnagi DanielVajnagi linked an issue Feb 13, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (2e994f7) to head (b7944bc).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1025   +/-   ##
========================================
  Coverage    98.71%   98.71%           
========================================
  Files           71       71           
  Lines         1011     1011           
========================================
  Hits           998      998           
  Misses          13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVajnagi DanielVajnagi self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MHC] Additions to the calculator
2 participants