Added tests for custom exceptions #556
Conversation
src/test/java/com/softserveinc/dokazovi/controller/AuthControllerTest.java
Show resolved
Hide resolved
src/test/java/com/softserveinc/dokazovi/controller/AuthControllerTest.java
Show resolved
Hide resolved
| UserEntity user = buildUserEntity(EMAIL, PASSWORD, true); | ||
| when(authenticationManager.authenticate(any(UsernamePasswordAuthenticationToken.class))) | ||
| .thenReturn(authentication); | ||
| when(tokenProvider.createToken(any(Authentication.class))).thenReturn(TOKEN); |
There was a problem hiding this comment.
Please make assertion on token value after post request.
| } | ||
|
|
||
| private Authentication authenticate(LoginRequest loginRequest) { | ||
| return authenticationManager.authenticate( |
There was a problem hiding this comment.
authenticationManager is mocked and couldn't provide proper response.
If I'm not mistaken, you can return
new UsernamePasswordAuthenticationToken(loginRequest.getEmail(), loginRequest.getPassword())
without calling authenticationManager
| verify(postRepository, never()) | ||
| .save(any(PostEntity.class) | ||
| ); | ||
|
|
There was a problem hiding this comment.
Please remove empty line
| Timestamp publishedAt = Timestamp.valueOf( | ||
| LocalDateTime.of( | ||
| LocalDate.of( | ||
| 2002, Month.JANUARY, 14), |
There was a problem hiding this comment.
Please move it on the same line with LocalDate.of(
| @@ -37,6 +40,8 @@ | |||
| @MockitoSettings(strictness = Strictness.LENIENT) | |||
| class AuthControllerTest { | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please remove excessive empty lines
| @@ -1278,6 +1279,79 @@ void updatePostById_WhenExists_isOk_DoctorRole() { | |||
| Assertions.assertThat(postService.updatePostById(userPrincipal, dto)).isTrue(); | |||
| } | |||
|
|
|||
| @Test | |||
| void updatePostById_WhenPostStatus_NotFount_ThrowException() { | |||
There was a problem hiding this comment.
NotFount it appears to be mistyping here. It should be NotFound
| .contentType(MediaType.APPLICATION_JSON) | ||
| .accept(MediaType.APPLICATION_JSON)) | ||
| .andExpect(status().isOk()); | ||
| assertEquals(TOKEN, tokenProvider.createToken(authentication)); |
There was a problem hiding this comment.
That assertion doesn't make sense because it uses mocked value result from line 81 when(tokenProvider.createToken(authentication)).thenReturn(TOKEN);
You should compare TOKEN with value in the response after POST request. In your case, it will look like
mockMvc.perform(MockMvcRequestBuilders.post(URI) .content(asJsonString(loginRequest)) .contentType(MediaType.APPLICATION_JSON) .accept(MediaType.APPLICATION_JSON)) .andExpect(status().isOk()) .andExpect(mvcResult -> mvcResult.getResponse().getContentAsString().equals(TOKEN));
develop
GitHub Board
Issue link
Tests for custom exceptions #555
Code reviewers
Summary of issue
Summary of change