Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade storybook #1044

Merged
merged 42 commits into from
Apr 9, 2024
Merged

Upgrade storybook #1044

merged 42 commits into from
Apr 9, 2024

Conversation

Virtute90
Copy link
Contributor

@Virtute90 Virtute90 commented Apr 3, 2024

Fixes #800

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Description of what this resolves:

Updating the storybook to the latest version:

  • Remaking of all stories based on the new specifications with typescript (ref)
  • Correction of the .mdx documentation part with the new version (v3)
  • New documentation structure
stories
    └── Components 
        ├── *stories.tsx
stories
    └── Documentation 
        ├── *.mdx
  • New builder/js tool Vitejs (which replaces webpack) much faster and more efficient
  • Replacement of old tests in the storybook with new ones (ref)
  • Fixed some typescript interfaces on some components
  • Removed/added some dependencies

Thank you very much to @sabato-galasso for the contribution!!!

Surely the new documentation will not be perfect but it is a good starting point!!

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Apr 9, 2024 8:21am

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (4d7e1a2) to head (31f4d7e).

❗ Current head 31f4d7e differs from pull request most recent head 934d0f6. Consider uploading reports for the commit 934d0f6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   94.47%   95.40%   +0.93%     
==========================================
  Files         291      291              
  Lines        3002     3003       +1     
  Branches      766      766              
==========================================
+ Hits         2836     2865      +29     
+ Misses        155      126      -29     
- Partials       11       12       +1     
Flag Coverage Δ
unittests 95.40% <100.00%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi merged commit 061315a into italia:main Apr 9, 2024
4 of 5 checks passed
@Virtute90 Virtute90 deleted the chcore/upgrade-storybook branch April 9, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] Upgrade to latest Storybook
3 participants