Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'to' prop to bottomnavitem #1047

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

Nick87
Copy link
Contributor

@Nick87 Nick87 commented Apr 8, 2024

Fixes #1046

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

A to has been added to the BottomNavItem component so that, if a react-route-dom's NavLink is used as tag, we can leverage its client-side routing capabilities

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Apr 9, 2024 0:42am

@astagi astagi merged commit 8126a98 into italia:main Apr 10, 2024
5 checks passed
@Nick87 Nick87 deleted the feature/bottom-nav-item-to branch April 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add 'to' prop to BottomNavItem
3 participants