Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new dropdown based on reactstrap #1071

Merged
merged 2 commits into from
Jun 24, 2024
Merged

feat: new dropdown based on reactstrap #1071

merged 2 commits into from
Jun 24, 2024

Conversation

astagi
Copy link
Member

@astagi astagi commented Jun 24, 2024

Fixes #

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Jun 24, 2024 2:27pm

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 99.31707% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.35%. Comparing base (1074d49) to head (bd4a8b3).
Report is 4 commits behind head on main.

Files Patch % Lines
stories/Components/Header/NavHeader.stories.tsx 98.18% 4 Missing ⚠️
...ories/Components/Header/CompleteHeader.stories.tsx 98.87% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   97.34%   97.35%           
=======================================
  Files         354      354           
  Lines       25462    25450   -12     
  Branches     1668     1670    +2     
=======================================
- Hits        24787    24776   -11     
+ Misses        673      672    -1     
  Partials        2        2           
Flag Coverage Δ
unittests 97.35% <99.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi merged commit 3e4eda6 into main Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant