Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: alert default props #1072

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

Virtute90
Copy link
Contributor

Fixes #1067

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Sostuito defaultprops con parametri del componenti

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Jun 28, 2024 10:57pm

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (db6a256) to head (2adf33d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   97.35%   97.35%   -0.01%     
==========================================
  Files         354      354              
  Lines       25450    25444       -6     
  Branches     1670     1670              
==========================================
- Hits        24776    24770       -6     
  Misses        672      672              
  Partials        2        2              
Flag Coverage Δ
unittests 97.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi merged commit 39821d9 into italia:main Jul 2, 2024
6 checks passed
@astagi
Copy link
Member

astagi commented Jul 2, 2024

Thanks @Virtute90

@Virtute90 Virtute90 deleted the fix/alert-default-props branch July 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: remove defaultProps on Alert
2 participants