Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 18 #967

Closed
wants to merge 21 commits into from
Closed

Upgrade to React 18 #967

wants to merge 21 commits into from

Conversation

sabato-galasso
Copy link
Collaborator

@sabato-galasso sabato-galasso commented Jun 7, 2023 •
edited
Loading

Fixes #

PR Checklist

  • My branch is up-to-date with the Upstream next branch.

Short description of what this resolves:

Changes proposed in this Pull Request:

  • Upgrade and migrate all classes, functions for React 18

@vercel
Copy link

vercel bot commented Jun 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 10:16am

federico-ntr and others added 3 commits June 8, 2023 16:53
@federico-ntr
Update Card component (italia#964)
f72d0ed 
* docs: fix wrong cursor due to missing href

* feat: force href to undefined if tag not anchor
@federico-ntr
Update Breadcrumbs to be BI 2.x compliant (italia#968)
92a4d8a 
* feat: change default aria-label

* fix: missing padding with dark container

* docs: remove anchor tag from the last crumb of the breadcrumbs
@sabato-galasso
removed bt-italia deps
a4bf036
@dej611
Copy link
Member

dej611 commented Jun 21, 2023

I would move for this in a difference direction:

  • leave the current example on React 17 and use it to perform CI build checks
  • create a new React 18 example and use it to perform CI build checks
  • if any change in React 18 would require some change in a component of the Kit, I will inline a note in the component example directly about the React 18 variant/differences

For the rest all react versions should be kept still compatible with React 17 in the kit.

Virtute90 and others added 5 commits October 5, 2023 15:06
@Virtute90
Add state per la corretta visualizzazione input (italia#974)
7f451b8
@tensor5
fix: set default value for text prop in input
8edd804
@federico-ntr @dej611
@astagi @sabato-galasso
feat: rework select to use reactstrap implementation
5124f2c 
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Co-authored-by: Andrea Stagi <stagi.andrea@gmail.com>
Co-authored-by: sabato-galasso <sabatogalasso90@gmail.com>
@sabato-galasso
feat: autocomplete component
bf2ba3d
@sabato-galasso
Merge branch 'italia:next' into next
108cc49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astagi astagi Awaiting requested review from astagi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sabato-galasso @dej611 @federico-ntr @astagi @Virtute90 @tensor5