Skip to content

Commit

Permalink
Add longer readiness check (#1595)
Browse files Browse the repository at this point in the history
* Add longer readiness check

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

* Add namespace to job check

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>

---------

Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
  • Loading branch information
Alan-Cha authored Aug 25, 2023
1 parent 658bd34 commit 42ea1ad
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/verifyuserexperience.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ jobs:
run: |
kubectl create deploy httpbin --image=kennethreitz/httpbin --port=80
kubectl expose deploy httpbin --port=80
# No kubectl wait so ready task can check
- name: k launch with readiness checks
run: |
Expand Down Expand Up @@ -418,9 +419,13 @@ jobs:
run: |
kubectl create deploy httpbin --image=kennethreitz/httpbin --port=80
kubectl expose deploy httpbin --port=80
# No kubectl wait so ready task can check
- name: Create experiments namespace
run: |
kubectl create namespace experiments
- name: k launch with readiness checks
- name: k launch with readiness checks and namespace
run: |
iter8 k launch -n experiments \
--set "tasks={ready,http}" \
Expand All @@ -430,7 +435,7 @@ jobs:
--set ready.namespace=default \
--set http.url=http://httpbin.default/get \
--set logLevel=trace
kubectl wait --for=condition=complete --timeout=180s job/default-1-job
kubectl wait --for=condition=complete --timeout=180s -n experiments job/default-1-job
- name: Get Kubernetes status
run: |
Expand Down

0 comments on commit 42ea1ad

Please sign in to comment.