fix comment

Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
iter8-tools · Sep 26, 2023 · 73d653e · 73d653e
1 parent 7c42911
commit 73d653e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/charts/routing-actions/templates/_deployment.routemap-bg.tpl b/charts/routing-actions/templates/_deployment.routemap-bg.tpl
@@ -42,7 +42,7 @@ data:
             - {{ .Values.appName }}.{{ .Release.Namespace }}.svc.cluster.local
             http:
             - route:
-              # primary model
+              # primary version
               - destination:
                   host: {{ (index $versions 0).name }}.{{ .Release.Namespace }}.svc.cluster.local
                   {{- if .Values.appPort }}
@@ -56,7 +56,7 @@ data:
                   response:
                     add:
                       app-version: {{ (index $versions 0).name }}
-              # other models
+              # other versions
               {{- range $i, $v := (rest $versions) }}
               {{ `{{- if gt (index .Weights ` }}{{ print (add1 $i) }}{{ `) 0 }}`}}
               - destination:

diff --git a/charts/routing-actions/templates/traffic.yaml b/charts/routing-actions/templates/traffic.yaml
@@ -10,11 +10,8 @@
   {{- printf "Unknown appType: '%s'" .Values.appType | fail }}
 {{- end }}
 
-{{- /* set default strategy */}}
-{{- $strategy := "none" }}
-{{- if .Values.strategy }}
-{{- $strategy := .Values.strategy }}
-{{- end }}
+{{- /* set strategy using default value if needed */}}
+{{- $strategy := (.Values.strategy | default "none" ) }}
 
 {{- /* validate values for strategy */}}
 {{- if not (has $strategy (list "blue-green" "canary" "none")) }}