Modify metric endpoints #1629
Merged
Modify metric endpoints #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Alan-Cha
commented
Sep 7, 2023
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
kalantar
previously requested changes
Sep 8, 2023
base/metrics.go
Outdated
| @@ -14,11 +14,11 @@ const ( | |||
| // MetricsServerURL is the URL of the metrics server | |||
| MetricsServerURL = "METRICS_SERVER_URL" | |||
|
|
|||
| // MetricsPath is the path to the GET /metrics endpoint | |||
| MetricsPath = "/metrics" | |||
|
|
|||
| // ExperimentResultPath is the path to the PUT /experimentResult endpoint | |||
| ExperimentResultPath = "/experimentResult" | |||
There was a problem hiding this comment.
should this also be changed to testResult ?
metrics/server.go
Outdated
|
|
||
| // identify the routemap for the application | ||
| namespace, name := util.SplitApplication(application) | ||
| namespace, name := util.SplitApplication(namespaceApplication) |
There was a problem hiding this comment.
this shouldn't be necessary any more. namespace name are namespace, application from a few lines above.
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Alan-Cha
force-pushed
the
experiment-test3
branch
from
5aa8edd
to
2090f12
Compare
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Alan-Cha
commented
Sep 8, 2023
Alan-Cha
commented
Sep 8, 2023
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
kalantar
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1620
Replace #1628