-
-
Notifications
You must be signed in to change notification settings - Fork 317
Interceptor for STS AssumeRole and GetSessionToken #17440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ckward compatibility.
…e ARN and MFA code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for an STS AssumeRole interceptor to handle AWS role assumption with static credentials, addressing issue #17437. It introduces a new interceptor for standard STS AssumeRole operations while refactoring the existing web identity-based interceptor.
- Creates a new
STSAssumeRoleRequestInterceptor
for standard role assumption with static AWS credentials - Renames existing class to
STSAssumeRoleWithWebIdentityRequestInterceptor
for clarity - Adds MFA support and improves configuration handling in the STS authorization service
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
STSAssumeRoleWithWebIdentityRequestInterceptor.java | Renamed class and constructor from STSAssumeRoleCredentialsRequestInterceptor for clarity |
STSAssumeRoleRequestInterceptor.java | New interceptor for standard STS AssumeRole operations using static credentials |
STSAssumeRoleAuthorizationService.java | Enhanced with new authorize method for static credentials and improved configuration handling |
S3Session.java | Updated credential strategy configuration to use renamed interceptor and support new role assumption flow |
default.properties | Added documentation comments for STS configuration properties |
HostPreferences.java | Added overloaded getProperty method supporting multiple fallback keys |
Profile.java | Added constants for STS-related property keys |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
s3/src/main/java/ch/cyberduck/core/sts/STSAssumeRoleRequestInterceptor.java
Outdated
Show resolved
Hide resolved
s3/src/main/java/ch/cyberduck/core/sts/STSAssumeRoleAuthorizationService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ch/cyberduck/core/preferences/HostPreferences.java
Outdated
Show resolved
Hide resolved
…tials) to use the stored static credentials instead of the current (potentially expired) tokens. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
bab324e
to
950c877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures.
7709d6b
to
7e5a594
Compare
…e Interface) connection profile.
e38fa3a
to
70255b9
Compare
a9bbed9
to
be36867
Compare
Uh oh!
There was an error while loading. Please reload this page.