skip some tests on Windows

pytest-celery is not supported on Windows.
iterative · May 10, 2024 · 44af473 · 44af473
1 parent a5dfe35
commit 44af473
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -42,6 +42,25 @@ jobs:
           pip --version
           nox --version
 
+      # https://github.com/iterative/pytest-servers/pull/122
+      # https://github.com/abiosoft/colima/issues/468
+      # https://github.com/abiosoft/colima/blob/main/docs/FAQ.md#cannot-connect-to-the-docker-daemon-at-unixvarrundockersock-is-the-docker-daemon-running
+      # colima v0.5.6 seems to run more stable than the latest - that has occasional network failures (ports are not open)
+      # see: https://github.com/abiosoft/colima/issues/962
+      - name: Use colima as default docker host on MacOS
+        if: runner.os == 'macOS'
+        run: |
+          brew install docker lima || true # avoid non-zero exit code if brew link fails
+          sudo curl -L -o /usr/local/bin/colima https://github.com/abiosoft/colima/releases/download/v0.5.6/colima-Darwin-x86_64
+          sudo chmod +x /usr/local/bin/colima
+          colima start
+          sudo ln -vsf "${HOME}"/.colima/default/docker.sock /var/run/docker.sock
+        env:
+          HOMEBREW_NO_AUTO_UPDATE: true
+          HOMEBREW_NO_INSTALL_CLEANUP: true
+          HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: true
+          HOMEBREW_NO_INSTALL_UPGRADE: true
+
       - name: Lint code and check dependencies
         run: nox -s lint safety
 

diff --git a/tests/proc/test_tasks.py b/tests/proc/test_tasks.py
@@ -1,5 +1,6 @@
 """Process task tests."""
 
+import os
 from typing import Any, Dict
 
 import pytest
@@ -10,6 +11,7 @@
 from dvc_task.proc.tasks import run
 
 
+@pytest.mark.skipif(os.name == "nt")
 @pytest.mark.usefixtures("celery_app", "celery_worker")
 def test_run(
     tmp_dir: TmpDir,

diff --git a/tests/worker/test_temporary.py b/tests/worker/test_temporary.py
@@ -1,5 +1,6 @@
 """Temporary Worker tests."""
 
+import os
 import sys
 
 import pytest
@@ -28,6 +29,7 @@ def test_start(celery_app: Celery, mocker: MockerFixture):
     thread.assert_called_once_with(target=worker.monitor, daemon=True, args=(name,))
 
 
+@pytest.mark.skipif(os.name == "nt")
 @pytest.mark.flaky(reruns=3, condition=sys.platform == "darwin")
 def test_start_already_exists(
     celery_app: Celery,
@@ -43,6 +45,7 @@ def test_start_already_exists(
     thread.assert_not_called()
 
 
+@pytest.mark.skipif(os.name == "nt")
 @pytest.mark.flaky(reruns=3, condition=sys.platform == "darwin")
 def test_monitor(
     celery_app: Celery,