Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: error out on import from cloud-versioned remote #9182

Closed
wants to merge 2 commits into from

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Mar 15, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Related: #8789

Exception will now be raised when importing a file from a DVC repo that would require cloud-versioned remotes.

$ dvc import ../scratch/cloud-versioning cats-dogs
Importing 'cats-dogs (../scratch/cloud-versioning)' -> 'cats-dogs'
ERROR: failed to import 'cats-dogs' from '../scratch/cloud-versioning'. - Target repository '../scratch/cloud-versioning' uses cloud-versioned remotes.: 'dvc import' is unsupported for cloud versioned remotes

@pmrowla pmrowla added ui user interface / interaction A: cloud-versioning labels Mar 15, 2023
@pmrowla pmrowla requested a review from dberenbaum March 15, 2023 06:06
@pmrowla pmrowla self-assigned this Mar 15, 2023
@pmrowla
Copy link
Contributor Author

pmrowla commented Mar 15, 2023

The error message ends up being a bit verbose due to the exception chaining (it gets nested inside the general import error, then the general erepo error) but should be good enough for now.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: -0.02 ⚠️

Comparison is base (c8745dd) 92.91% compared to head (c921972) 92.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9182      +/-   ##
==========================================
- Coverage   92.91%   92.90%   -0.02%     
==========================================
  Files         456      456              
  Lines       36869    36888      +19     
  Branches     5322     5326       +4     
==========================================
+ Hits        34258    34269      +11     
- Misses       2087     2092       +5     
- Partials      524      527       +3     
Impacted Files Coverage Ξ”
dvc/data_cloud.py 82.19% <50.00%> (ΓΈ)
dvc/config.py 98.04% <66.66%> (-0.47%) ⬇️
dvc/exceptions.py 95.07% <66.66%> (-0.62%) ⬇️
dvc/dependency/repo.py 92.95% <80.95%> (-2.57%) ⬇️
dvc/external_repo.py 81.17% <83.33%> (-0.65%) ⬇️
dvc/output.py 88.67% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@efiop
Copy link
Contributor

efiop commented Mar 15, 2023

#9181 introduces index support for repo imports including cloud versioned stuff and cycles. The obj-related code probably will get removed and we would use fs directly like we do with regular import-urls.

@pmrowla pmrowla closed this Mar 15, 2023
@pmrowla pmrowla deleted the 8789-versioned-import-msg branch March 15, 2023 14:39
@efiop
Copy link
Contributor

efiop commented Mar 15, 2023

@pmrowla Sorry for wasting your time on this, meant to discuss it today. πŸ™

@dberenbaum dberenbaum mentioned this pull request Mar 15, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants