Move bounding box class legend into its own collapsible row #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Jan 26, 2024
| <td | ||
| className={cx({ [styles.pinnedColumnCell]: pinnedColumn })} | ||
| colSpan={pinnedColumn ? 1 : nbColumns} | ||
| <ComparisonTablePinnedContentRow |
There was a problem hiding this comment.
I decided to keep the path sticky but we also could keep it static as before:
Screen.Recording.2024-01-26.at.7.41.16.AM.mov
There was a problem hiding this comment.
I feel like it was better before. It feels weird to move the classes but not the path.
| delay={NORMAL_TOOLTIP_DELAY} | ||
| <div | ||
| data-testid="row-bounding-box-classes" | ||
| className={cx(styles.boundingBoxClasses, cellClasses)} |
There was a problem hiding this comment.
I did test out making the animation of the classes collapsing a bit smoother, but decided to keep it as is:
Screen.Recording.2024-01-25.at.5.43.36.PM.mov
sroy3
approved these changes
Jan 26, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main<- #5227 <- thisDemo
Screen.Recording.2024-01-26.at.7.36.04.AM.mov
Resolves #5227 (comment)