-
Notifications
You must be signed in to change notification settings - Fork 2
Readthedocs gh actions and iwrap plugins integration #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Readthedocs gh actions and iwrap plugins integration #1
Conversation
… file issue when pip install
|
|
||
| 3. **Design Clear Port Interfaces** | ||
|
|
||
| Plan your MUSCLE3 ports carefully to ensure clear data flow between components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean? In this version of MUSCLE3 actors the type of ports for input and output is fixed no?
--> what's missing in this doc is to say somewhere that this is only handling a KIND of M3 actor (F_init / O_f), but MUSCLE3 allows more advanced actor and coupling scenarios, which have to be implemented manually (link to M3 doc)
|
|
||
| Validate your yMMSL files before running to catch configuration errors early. | ||
|
|
||
| Troubleshooting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine having some troubleshooting but:
- in a single / well identified place
- kept up to date
| - `MUSCLE3 GitHub Repository <https://github.com/multiscale/muscle3>`_ | ||
| - `iWrap Examples with MUSCLE3 <../tutorial/>`_ | ||
|
|
||
| Migration from External Plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is useful, all current users are anyway only loading environement modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet another install description, it's been the 4th time I'm reading this or alternate version of it, please centralize. 5 min starting guide may still prove useful, but focus on use and not installation.
Co-authored-by: Olivier Hoenen <Olivier.Hoenen@iter.org>
Co-authored-by: Olivier Hoenen <Olivier.Hoenen@iter.org>
Integrated MUSCLE3 plugins
Added readthedocs.yml
Added workflow for pypi/testpypi
Fixed CI issues on bamboo