Release/1.2.0 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IMASPy-get_sample
In preparation for validating the NC data
…IMASPy-get_sample
Feature not yet implemented, see IMAS-5593
Merge in IMAS/imaspy from feature/refactor-nc2ids to develop * commit 'd59fcabc29d5691004649bcf48016255010d7fa7': Add missing docstring Make the NC2IDS reader class-based
Ensure lazy contexts belonging to a different IDS are always closed. See IMAS-5603 for more details.
…has no effect on the `ids.time` vector. See also https://git.iter.org/projects/IMAS/repos/al-matlab/pull-requests/29/overview?commentId=48957
… same HDF5 DBEntry Merge in IMAS/imaspy from bugfix/IMAS-5603 to develop * commit 'e5246464d588069af3f0f25e5a0e00d41d7fd4ef': Fix a bug with lazy loading multiple IDSs from the same HDF5 DBEntry
Also fix a couple of bugs when opening invalid netCDF files and raise a proper exception.
Merge in IMAS/imaspy from feature/IMAS-3885-IMASPy-get_sample to develop * commit 'afb8c292c6527f03354ac35fa43dfaebd8fb4ef3': Update `get_sample` docstring to clarify that the interpolation mode has no effect on the `ids.time` vector. Disable MDSplus backend tests for get_sample Set `begin_timerange_action` as available since AL core 5.4 Update NCDBEntryImpl for get_sample and raise NotImplementedError Update tests for DD 4.0.0 Add docstrings for GetSliceParameters / GetSampleParameters Implement `DBEntry.get_sample` in IMASPy
Merge in IMAS/imaspy from feature/cli_validate_nc to develop * commit 'fc2cbf20b3cf1c549761214109d3d89b4ee34091': Additional documentation for the `imaspy validate_nc` command line tool Add unit tests for `nc_validate.py` Close netCDF datasets when an exception is raised Fix incorrect exception when using mode="x" for netCDF files Add `validate_nc` command to imaspy CLI
Merge in IMAS/imaspy from fix/license-references to develop * commit 'd80778fe6cdadf50255a50905a00ed9e2b458c8c': Replace references to LICENSE.md to LICENSE.txt
…4.0.0 (change in schemas layout) Merge in IMAS/imaspy from identifiers-dd-schemas-layout to develop * commit '74d2e3afe41a3fb907bc0a3729fcea29590aa4ca': Make prepare_data_dictionaries compatible with DD>4.0.0 (change in schemas layout)
Bug: IMASPy runs into an attribute error when lazy loading a child quantity that was added in a newer DD version than stored on disk. Example: 1. Equilibrium IDS stored in DD 3.33.0 2. Lazy loading IDS with DD 4.0.0 3. Try to access `eq.time_slice[0].boundary.dr_dz_zero_point.r` resulted in an AttributeError Root cause: IMASPy did not handle correctly that the `dr_dz_zero_point` was added between 3.33.0 and 4.0.0. This commit fixes the bug.
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
|
Plan is to have the rename PR finished soon, and create a 2.0 release afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olivhoenen I think now is a good moment for a release before doing the major rename in #6. Please let me know what you think and if there's anything missing.
TODO before merging:
docs/source/changelog.rstWhat's new in IMASPy 1.2.0
DBEntry.get_sample(requiresimas_core> 5.4.0)imas_coreBug fixes