Pull Request to create/update 'rebased/object-loader-logging' branch #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains UX and error handling fixes with the object loading dialog. Should fix issues found, when testing #36. |
Eswcvlad
force-pushed
the
object-loader-logging
branch
from
b62e8d6 to
43eced6
Compare
As it turns out, SwingWorker still called done, even if the body of the task itself threw an exception. So it just pushes the open event, even though `nodes` is null. What's annoying, is that there doesn't seem to be a good mechanism for getting that exception... You either need to handle it yourself within `doInBackground` and then read that exception data in `done`, or abuse `SwingWorker::get` and catch an `ExecutionException`. See issue #36 for discovery.
This already happened in previous version without the recent changes. There could be a race, where raw setVisible(false) call executes before the initial invokeLater call to show it in the first place.
* The dialog is now resizeable. * Default size of the dialog now is set to the smallest size, which can fit the whole message without scrolling. But with a limit based on the display size.
Update getTraceString in ErrorDialogPane to show the error message and cause, if available.
Eswcvlad
force-pushed
the
object-loader-logging
branch
from
1aeaf77 to
8e37ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programmatically created Pull Request to automatically keep merge branch to develop up-to-date