Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Asset import #715

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Bug fix: Asset import #715

merged 1 commit into from
Sep 9, 2023

Conversation

wrongecho
Copy link
Collaborator

  • Increase allowed asset import column count to accommodate extra fields previously added.
  • Better error handling for invalid/empty columns

https://forum.itflow.org/d/348-import-assets-bad-column-count-error

@wrongecho
Copy link
Collaborator Author

Test these changes at: https://assetimport715.pr-review.itflow.org
(automatic message)

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
21.3% 21.3% Duplication

@wrongecho
Copy link
Collaborator Author

Asset CSV Import is currently broken entirely.
Tested changes on PR Review instance & Working fine - merging in to fix feature.

@wrongecho wrongecho merged commit 89d4f85 into itflow-org:master Sep 9, 2023
4 checks passed
@wrongecho wrongecho deleted the asset-import branch September 9, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wrongecho