-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme with install script #737
Update readme with install script #737
Conversation
Test these changes at: https://Updatereadmewithinstallscript737.pr-review.itflow.org |
Hey @o-psi, thanks for the PR! The install script is definitely the recommended method to install, it's so much quicker than manually installing Apache and cloning everything yourself. I've just made a few small tweaks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with tweaks
Updated oneliner to pipe the script directly to bash.
Kudos, SonarCloud Quality Gate passed! |
Thanks @wrongecho. I slightly modified the script output the wget as standard output, and pipe into bash directly, avoiding saving the script unless the user actually wants to. |
Nice work! Thank you :) |
Updated README.MD to show updated install instructions.