Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with install script #737

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Update readme with install script #737

merged 5 commits into from
Oct 8, 2023

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Oct 8, 2023

Updated README.MD to show updated install instructions.

@wrongecho
Copy link
Collaborator

Test these changes at: https://Updatereadmewithinstallscript737.pr-review.itflow.org
(automatic message)

@wrongecho
Copy link
Collaborator

Hey @o-psi, thanks for the PR!

The install script is definitely the recommended method to install, it's so much quicker than manually installing Apache and cloning everything yourself. I've just made a few small tweaks:

  • The security/in development message is already shown further up ("In beta") so doesn't need to be shown again.

  • Moved the security policy link to the top header to make it more visible.

  • Combine the download/install commands into one

Copy link
Collaborator

@wrongecho wrongecho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with tweaks

Updated oneliner to pipe the script directly to bash.
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@o-psi
Copy link
Contributor Author

o-psi commented Oct 8, 2023

Thanks @wrongecho. I slightly modified the script output the wget as standard output, and pipe into bash directly, avoiding saving the script unless the user actually wants to.

@wrongecho
Copy link
Collaborator

Nice work! Thank you :)

@wrongecho wrongecho merged commit f1b017f into itflow-org:master Oct 8, 2023
3 checks passed
@o-psi o-psi deleted the Update-readme-with-install-script branch October 10, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants