fix: address linting issues

ithaka · Jan 4, 2024 · 7357d63 · 7357d63
1 parent dc251a5
commit 7357d63
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/packages/pharos/src/components/checkbox/PharosCheckbox.react.stories.jsx b/packages/pharos/src/components/checkbox/PharosCheckbox.react.stories.jsx
@@ -118,7 +118,7 @@ export const Validity = {
   },
 };
 
-export const isOnBackground = {
+export const IsOnBackground = {
   name: 'On background',
   render: () => (
     <div>

diff --git a/packages/pharos/src/components/checkbox/pharos-checkbox.wc.stories.jsx b/packages/pharos/src/components/checkbox/pharos-checkbox.wc.stories.jsx
@@ -105,7 +105,7 @@ export const Validity = {
   },
 };
 
-export const isOnBackground = {
+export const IsOnBackground = {
   name: 'On background',
   render: () =>
     html`

diff --git a/packages/pharos/src/components/dropdown-menu/PharosDropdownMenu.react.stories.jsx b/packages/pharos/src/components/dropdown-menu/PharosDropdownMenu.react.stories.jsx
@@ -178,7 +178,7 @@ export const FullWidth = {
   ),
 };
 
-export const isOnBackground = {
+export const IsOnBackground = {
   render: () => (
     <div
       style={{

diff --git a/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.wc.stories.jsx b/packages/pharos/src/components/dropdown-menu/pharos-dropdown-menu.wc.stories.jsx
@@ -178,7 +178,7 @@ export const FullWidth = {
   },
 };
 
-export const isOnBackground = {
+export const IsOnBackground = {
   render: () => {
     const effect = () => {
       useEffect(() => {

diff --git a/packages/pharos/src/components/toast/pharos-toast.test.ts b/packages/pharos/src/components/toast/pharos-toast.test.ts
@@ -67,9 +67,9 @@ describe('pharos-toast', () => {
   });
 
   it('fires a custom event pharos-toast-close after closing', async () => {
-    let detail = null;
+    let actualId = '';
     const handleClose = (e: Event): void => {
-      detail = (e as CustomEvent).detail;
+      actualId = (e as CustomEvent).detail.id;
     };
     component.addEventListener('pharos-toast-close', handleClose);
 
@@ -81,6 +81,6 @@ describe('pharos-toast', () => {
     await component.updateComplete;
     await aTimeout(500);
 
-    expect((detail as any).id === component.id).to.be.true;
+    expect(actualId === component.id).to.be.true;
   });
 });