Skip to content

Commit

Permalink
chore(infra): upgrade to Node.js 18 (#529)
Browse files Browse the repository at this point in the history
* chore(infra): upgrade to Node.js 18

* fix(tests): update WTR versions and config

* fix(deps): update registry
  • Loading branch information
daneah authored May 17, 2023
1 parent 2434b65 commit c677cae
Show file tree
Hide file tree
Showing 9 changed files with 347 additions and 182 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
with:
fetch-depth: 0

- name: Setup Node.js 16.x
- name: Setup Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
registry-url: 'https://registry.npmjs.org'

- name: Get yarn cache directory path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
fetch-depth: 0

- name: Setup Node.js 16.x
- name: Setup Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
registry-url: 'https://registry.npmjs.org'

- name: Get yarn cache directory path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/size-limit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Setup Node 16.x
- name: Setup Node 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Setup Node 16.x
- name: Setup Node 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -44,10 +44,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Setup Node 16.x
- name: Setup Node 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 16.18.0
nodejs 18.16.0
2 changes: 1 addition & 1 deletion docs/development/quick-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Start by cloning the Pharos repository:
$ git clone git@github.com:ithaka/pharos.git
```

Pharos supports the current long-term support (LTS) version of Node.js—currently version 16. Node can be installed from [its website](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm#install--update-script), or with [asdf](https://asdf-vm.com/) and its [Node.js plugin](https://github.com/asdf-vm/asdf-nodejs).
Pharos supports the current long-term support (LTS) version of Node.js—currently version 18. Node can be installed from [its website](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm#install--update-script), or with [asdf](https://asdf-vm.com/) and its [Node.js plugin](https://github.com/asdf-vm/asdf-nodejs).

If you're using `nvm`, run the following command to switch to a Node version compatible with the project:

Expand Down
6 changes: 3 additions & 3 deletions packages/pharos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@
"@open-wc/testing": "^3.0.1",
"@types/react": "^17.0.1",
"@types/react-dom": "^17.0.0",
"@web/test-runner": "^0.15.0",
"@web/test-runner-commands": "^0.6.5",
"@web/test-runner-playwright": "^0.9.0",
"@web/test-runner": "^0.16.1",
"@web/test-runner-commands": "^0.7.0",
"@web/test-runner-playwright": "^0.10.0",
"autoprefixer": "^10.4.0",
"cem-plugin-readonly": "^0.0.2",
"chokidar": "^3.5.2",
Expand Down
1 change: 1 addition & 0 deletions packages/pharos/web-test-runner.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export default {
nodeResolve: true,
concurrentBrowsers: 3,
coverage: true,
testsStartTimeout: 30000,
coverageConfig: {
threshold: {
statements: 98,
Expand Down
Loading

0 comments on commit c677cae

Please sign in to comment.