feat(cli): add newly created components created using pharos-cli to initComponents files #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitComponents files
satya-achanta-venkata
requested review from
SMQuazi,
mtorres3 and
shoupeva-ithaka
and removed request for
a team
🦋 Changeset detectedLatest commit: eeb0420 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
daneah
reviewed
Oct 11, 2023
daneah
approved these changes
Oct 26, 2023
satya-achanta-venkata
deleted the
feature/add-new-components-to-initComponents
branch
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
…nitComponents files (ithaka#630) * feat(cli): add newly created components created using pharos-cli to initComponents files * feat(cli): use forEach to iterate files and also add new console log message * feat(cli): update log color from green to yellow * feat(cli): add new script that uses ts-morph to update initComponents files * feat(cli): empty commit to trigger actions * feat(cli): find nodes dynamically using syntax kind instead of index * feat(cli): update artifactory link for ts-morph package * feat(cli): update artifactory link for ts-morph package
daneah
added a commit
that referenced
this pull request
Dec 19, 2023
* develop: A11y revamp: Pharos buttons (non-breaking change) (#628) Radio, Checkbox: Fix group label (#652) Add elevation tokens and documentation (#643) fix(sidenav-link): external link opens in new tab (#645) Upgrade to TypeScript 5 (#644) feat(cli): add newly created components created using pharos-cli to initComponents files (#630) chore: version packages (#640) Coach Mark: Fix react component positioning (#638) Coach Mark: Documentation fixes (#639) chore(deps): bump @babel/traverse from 7.20.0 to 7.23.2 (#637) chore: version packages (#636) Icon: Add Panorama icon (#631) chore: version packages (#629) Loading spinner: add small and on background variant (#627) chore: version packages (#626) Sheet: allow expansion with attribute (#625) fix(button): remove fill on subtle disabled button on background (#618) chore(deps-dev): bump postcss from 8.4.25 to 8.4.31 (#624) chore: version packages (#623) Sheet: Add more close options and transition timing function (#620)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
In #590 , After creating new components using
pharos-cli, we had to make manual changes toinitComponents.[j|t]sfiles to components being recognized by tests. We found a room to automate the step of adding newly created components toinitComponentsfiles so that developer no need to make manual changes.How does this change work?
For example: If we create new component using
pharos wc yahoo, new component wil automatically be added topackages/pharos/src/initComponent.tsand.storybook/initComponents.jsfiles.Additional context
Try this by following below steps:
pharos wc treslechespackages/pharos/src/initComponent.ts.storybook/initComponents.js