Conversation
|
Contributor
size-limit report 📦
|
shoupeva-ithaka
requested review from
mtorres3,
satya-achanta-venkata and
shoupeva-ithaka
and removed request for
a team
Adds a new storybook page for the new elevation tokens in both react and web component flavors.
daneah
added
documentation
status/code review
design tokens
and removed
status/work in progress
labels
daneah
requested changes
Nov 7, 2023
packages/pharos-site/static/images/brand-expressions/elevation/elevation_stack_guide.jpg
Show resolved
Hide resolved
daneah
approved these changes
Nov 29, 2023
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
* docs(elevation): starter elevation documentation * Empty-Commit * Empty-Commit * docs(elevation): fix build errors * feat(elevation): add elevation tokens and pharos site pages * docs(elevation): add storybook stories Adds a new storybook page for the new elevation tokens in both react and web component flavors. * docs(elevation): remove accidentally included file * docs(elevation): added tokens to brand expressions page * docs: elevation update * docs(site): add elevation link to tokens sidenav section * docs: elevation final update * docs: elevation final update * chore: add changeset --------- Co-authored-by: Njoki Kamau <nkamau@r-nkamau.mynetworksettings.com> Co-authored-by: Njoki Kamau <Njoki.kamau@ithaka.org> Co-authored-by: Markell Torres <markell.torres@ithaka.org> Co-authored-by: Markell Torres <54967638+mtorres3@users.noreply.github.com> Co-authored-by: Evan Shoup <112417900+shoupeva-ithaka@users.noreply.github.com> Co-authored-by: Brent Swisher <brent.swisher@ithaka.org> Co-authored-by: Dane Hillard <github@danehillard.com>
daneah
added a commit
that referenced
this pull request
Dec 19, 2023
* develop: A11y revamp: Pharos buttons (non-breaking change) (#628) Radio, Checkbox: Fix group label (#652) Add elevation tokens and documentation (#643) fix(sidenav-link): external link opens in new tab (#645) Upgrade to TypeScript 5 (#644) feat(cli): add newly created components created using pharos-cli to initComponents files (#630) chore: version packages (#640) Coach Mark: Fix react component positioning (#638) Coach Mark: Documentation fixes (#639) chore(deps): bump @babel/traverse from 7.20.0 to 7.23.2 (#637) chore: version packages (#636) Icon: Add Panorama icon (#631) chore: version packages (#629) Loading spinner: add small and on background variant (#627) chore: version packages (#626) Sheet: allow expansion with attribute (#625) fix(button): remove fill on subtle disabled button on background (#618) chore(deps-dev): bump postcss from 8.4.25 to 8.4.31 (#624) chore: version packages (#623) Sheet: Add more close options and transition timing function (#620)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Resolves #641