Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update GitHub Actions and Node versions #704

Merged
merged 3 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup Node.js 18.x
uses: actions/setup-node@v3
- name: Setup Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "YARN_CACHE_DIR=.yarn/cache" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
- uses: actions/cache@v4
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: |
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
fetch-depth: 0

- name: Setup Node.js 18.x
uses: actions/setup-node@v3
- name: Setup Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "YARN_CACHE_DIR=.yarn/cache" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
- uses: actions/cache@v4
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: |
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/size-limit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ jobs:
env:
CI_JOB_NUMBER: 1
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Node 18.x
uses: actions/setup-node@v3
- name: Setup Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "YARN_CACHE_DIR=.yarn/cache" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
- uses: actions/cache@v4
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: |
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ jobs:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Node 18.x
uses: actions/setup-node@v3
- name: Setup Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "YARN_CACHE_DIR=.yarn/cache" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
- uses: actions/cache@v4
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: |
Expand All @@ -42,18 +42,18 @@ jobs:
name: Test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Node 18.x
uses: actions/setup-node@v3
- name: Setup Node 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "YARN_CACHE_DIR=.yarn/cache" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
- uses: actions/cache@v4
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 18.19.1
nodejs 20.11.1
Binary file modified .yarn/install-state.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion docs/development/quick-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Start by cloning the Pharos repository:
$ git clone git@github.com:ithaka/pharos.git
```

Pharos supports the current long-term support (LTS) version of Node.js—currently version 18. Node can be installed from [its website](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm#install--update-script), or with [asdf](https://asdf-vm.com/) and its [Node.js plugin](https://github.com/asdf-vm/asdf-nodejs).
Pharos supports the current long-term support (LTS) version of Node.js—currently version 20. Node can be installed from [its website](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm#install--update-script), or with [asdf](https://asdf-vm.com/) and its [Node.js plugin](https://github.com/asdf-vm/asdf-nodejs).

If you're using `nvm`, run the following command to switch to a Node version compatible with the project:

Expand Down
8 changes: 4 additions & 4 deletions packages/pharos-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
"pharos": "dist/index.js"
},
"devDependencies": {
"@types/jest": "^26.0.15",
"@types/node": "^14.14.6",
"@types/jest": "^29.5.12",
"@types/node": "^20.11.25",
"jest": "^29.7.0",
"ts-jest": "^29.1.1",
"ts-morph": "^20.0.0",
"ts-node": "^10.0.0",
"ts-morph": "^21.0.1",
"ts-node": "^10.9.2",
"typescript": "^5.2.2"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/pharos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"@web/test-runner-playwright": "^0.10.0",
"autoprefixer": "^10.4.0",
"cem-plugin-readonly": "^0.0.2",
"chokidar": "^3.5.2",
"chokidar": "^3.6.0",
"globby": "^12.0.0",
"minify-html-literals": "^1.3.5",
"postcss": "^8.4.31",
Expand Down
2 changes: 1 addition & 1 deletion packages/pharos/src/utils/registerComponents.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import PharosComponentMixin from './mixins/pharos-component';
* @param prefix The prefix to use in the tag name.
* @param classes The Pharos classes to register as custom elements.
*/
const registerComponents = (prefix: string, classes: typeof LitElement[]): void => {
const registerComponents = (prefix: string, classes: (typeof LitElement)[]): void => {
classes.forEach((clazz) => {
const kebab = clazz.name
.replace(/([a-z])([A-Z])/g, '$1-$2')
Expand Down
Loading
Loading