Skip to content

feat/feedback-icon: Add Feedback icon #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

satya-achanta-venkata
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Add Feedback icon

@satya-achanta-venkata satya-achanta-venkata requested a review from a team as a code owner June 18, 2024 14:00
@satya-achanta-venkata satya-achanta-venkata requested review from daneah, sirrah-tam and mtorres3 and removed request for a team June 18, 2024 14:00
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 9040db7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 18, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.63 KB (0%)

@brentswisher
Copy link
Contributor

You chromatic build has some odd changes, but I think those might be from a previous PR? https://www.chromatic.com/build?appId=60919c26122bd50039b34644&number=1624

@satya-achanta-venkata
Copy link
Contributor Author

@brentswisher Yes, those changes are from previous PR.

@satya-achanta-venkata satya-achanta-venkata merged commit 73b839d into develop Jun 20, 2024
7 checks passed
@satya-achanta-venkata satya-achanta-venkata deleted the feature/feedback-icon branch June 20, 2024 14:20
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants