Gatsby 5 upgrade #776
Gatsby 5 upgrade #776
Conversation
This reverts commit 553e564.
We still need to fix several components
Previously we used react-live to render the components samples in the component pages. This is duplication of the functionality storybook provides and increases the complexity of the site.
Remove the live and render options and updates it to take a string in instead of a children prop.
daneah
requested review from
sirrah-tam,
jialin-he and
mtorres3
and removed request for
a team
🦋 Changeset detectedLatest commit: 59c60f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
I was getting an error when building that doesn't show up when running yarn develop, didn't have a ton of time to look into it, something with SSR |
|
I'm meeting with David tomorrow to talk about the examples design a bit too, fwiw |
|
@brentswisher @david-corneail let us not let that discussion prevent us from merging this change, as this represents literal months of struggle and frustration—we need to lock in what value we have here and iterate. The SSR issue is particularly frustrating as it is not of large importance to this project—but we should prioritize fixing it nonetheless mostly again to be able to get past this initial large hurdle. I spent a little bit looking at it and am able to get around it on a page-by-page basis, but it's tedious and doesn't feel like the correct overall approach. |
|
So this seems to be the cause of the error 😞 I'm not familiar with |
|
After talking with @sirrah-tam I'm gonna see if I can just swap in https://focus-trap.github.io/focus-trap/. We may be able to eliminate it, or at least some of the uses of it, but that would be a little more complicated |
|
Bit of an aside, but we might want to look at the newly available Popover API at some point in the future which I understand has some amount of focus trapping capabilities out of the box. |
|
@daneah - @david-corneail and I updated the examples, in some of them (links, breadcrumbs) it wasn't entirely clear they were an example. I also extracted it into a component so we can iterate on it later easier Before:
After:
|
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
How does this change work?