Update dependencies #837
Merged
Update dependencies #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one exception: @lit-labs/scoped-registry-mixin. Updating it is breaking our unit tests with an odd type error, so punting on that update for now.
Because the label is on the icon inside a button, when webkit renders it, it is failing our axe a111y tests.
brentswisher
requested review from
sirrah-tam,
jialin-he and
mtorres3
and removed request for
a team
🦋 Changeset detectedLatest commit: 899f070 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brentswisher
added
accessibility
dependencies
size-limit report 📦
|
satya-achanta-venkata
approved these changes
Dec 6, 2024
daneah
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Updates dependencies to resolve some open CVEs
How does this change work?
Additional context
@lit-labs/scoped-registry-mixinas it breaks when updated past 1.0.1pharos-buttonwith an icon in the combobox because it causes some styling issues. The way we were providing the label on the icon inside a button wasn't working as intended in webkit, so I changed it to set aaria-labelon the button itself and mark the icon as hidden. We could also look into using apharos-input-grouphere instead. I'll add an issue for that but wanted to get the updates out first since that looked a little more involved.