Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nvim_buf_set_name causing Vim:E95 on Lazy reload #13

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

dpi0
Copy link
Contributor

@dpi0 dpi0 commented Sep 26, 2024

Fixes #12

Copy link
Owner

@itmecho itmecho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as it does fix the issue but I think it would be better to keep track of a single terminal buffer across reloads as if you reload the plugin multiple times you end up with multiple unlisted terminal session buffers

@itmecho itmecho merged commit 5389334 into itmecho:main Sep 27, 2024
1 check passed
@dpi0
Copy link
Contributor Author

dpi0 commented Sep 27, 2024

I'll merge this as it does fix the issue but I think it would be better to keep track of a single terminal buffer across reloads as if you reload the plugin multiple times you end up with multiple unlisted terminal session buffers

Right! will work on this.

@itmecho
Copy link
Owner

itmecho commented Sep 27, 2024

@dpi0 I've just pushed a commit to main that covers this by storing the bufh in a global variable and pulling it back into the state during setup.

Thanks for your initial fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error Vim:E95 on Lazy reload [bug]
2 participants