Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/scanner): finalize integration #157

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ivangabriele
Copy link
Owner

@ivangabriele ivangabriele commented Sep 15, 2024

Description

Finalize all core modules related to the Scanner feature, including its complete Webview integration.

Checklist

  • I updated the documentation accordingly. Or I don't need to.
  • I updated the tests accordingly. Or I don't need to.

@ivangabriele ivangabriele added os:debian os:windows os:macos feature:approved Approved new feature or feature enhancement. labels Sep 15, 2024
@ivangabriele ivangabriele added this to the v0.4 milestone Sep 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 2.40964% with 81 lines in your changes missing coverage. Please review.

Project coverage is 30.86%. Comparing base (464375e) to head (88eb5b3).

Files with missing lines Patch % Lines
src-tauri/src/modules/scanner/commands.rs 0.00% 18 Missing ⚠️
src-tauri/src/modules/scanner/state.rs 0.00% 17 Missing ⚠️
src-tauri/src/modules/scanner/utils.rs 0.00% 14 Missing ⚠️
src-tauri/filer/src/file_list.rs 0.00% 11 Missing ⚠️
src-tauri/src/lib.rs 0.00% 7 Missing ⚠️
src/libs/CoreStateHub/useCoreStateHub.ts 0.00% 7 Missing ⚠️
src/libs/CoreStateHub/index.ts 0.00% 6 Missing ⚠️
src/components/FileExplorer/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   32.29%   30.86%   -1.44%     
==========================================
  Files          33       36       +3     
  Lines         870      917      +47     
  Branches       15       16       +1     
==========================================
+ Hits          281      283       +2     
- Misses        585      634      +49     
+ Partials        4        0       -4     
Flag Coverage Δ
core 32.43% <2.89%> (-1.16%) ⬇️
webview 18.00% <0.00%> (-2.69%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivangabriele ivangabriele force-pushed the ivan/feat-core-scanner-finalize-integration branch from 3fe2658 to 88eb5b3 Compare November 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:approved Approved new feature or feature enhancement. os:debian os:macos os:windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants