Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added frontend for mindspore.ops.hardswish #21275

Merged
merged 6 commits into from
Aug 20, 2023
Merged

Added frontend for mindspore.ops.hardswish #21275

merged 6 commits into from
Aug 20, 2023

Conversation

jindalai
Copy link
Contributor

@jindalai jindalai commented Aug 4, 2023

Close #21274

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@jindalai
Copy link
Contributor Author

jindalai commented Aug 6, 2023 •
edited
Loading

@xoiga123
Resolved merge conflicts
Lint is failing on line 105 of tests file, which is not part of my code. It is part of the pad function

xoiga123
xoiga123 suggested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@xoiga123 xoiga123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yashj8, sorry for the late reply. Thank you for contributing to Ivy ⭐ The implementation seems good but maybe you haven't finished the test?

...ests/test_ivy/test_frontends/test_mindspore/test_ops/test_function/test_mindspore_nn_func.py Outdated Show resolved Hide resolved
@jindalai jindalai requested a review from xoiga123 August 11, 2023 05:37
@jindalai
Copy link
Contributor Author

Hi @xoiga123!
I have restored the code for the test
Kindly take a look and let me know of any other requirements 😄
Thanks!

xoiga123
xoiga123 reviewed Aug 11, 2023
View reviewed changes
ivy/functional/frontends/mindspore/ops/function/nn_func.py
Comment on lines +43 to +51
"2.0 and below": (
"int8",
"int16",
"int32",
"int64",
"float16",
"float32",
"float64",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I haven't noticed this before in the earlier review, but where did you find this info? It sounds correct but I can't seem to find it anywhere in their docs or code...

Copy link
Contributor Author

@jindalai jindalai Aug 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation

In the documentation it says :

Raises
Type Error– If dtype of x is not int or float

So I inferred from that to use all possible int and float that mindspore supports (just like numpy)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know of any further requirements 😄

@jindalai jindalai requested a review from xoiga123 August 11, 2023 07:53
@ivy-seed ivy-seed assigned satakshigarg and unassigned xoiga123 Aug 11, 2023
@jindalai
Copy link
Contributor Author

Hello @satakshigarg! Can you please take a look at it and let me know of any required changes? This PR is awaiting review from you for a while.
Thanks 😄

@satakshigarg
Copy link
Contributor

Thanks @yashj8 for your contributions !!
It looks good to me !!

Keep contributing 😃

@satakshigarg satakshigarg merged commit d4ec62b into ivy-llc:main Aug 20, 2023
398 of 399 checks passed
@jindalai
Copy link
Contributor Author

Thanks a lot @satakshigarg !!😄
Feels great to have my first PR merged!

Looking forward to many more down the line..

@jindalai jindalai deleted the hardswish branch August 21, 2023 20:01
@jindalai jindalai mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoiga123 xoiga123 Awaiting requested review from xoiga123

Assignees

@satakshigarg satakshigarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hardswish
3 participants
@jindalai @satakshigarg @xoiga123