Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Added kaiser_bessel_derived_window to tensorflow frontend #22517

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

waqaarahmed
Copy link
Contributor

@waqaarahmed waqaarahmed commented Aug 25, 2023

Closes #21877
Added kaiser_bessel_derived_window function to ivy/functional/frontend/tensorflow/signal.py
And Added test_kaiser_bessel_derived_window to ivy_tests/test_ivy/test_frontends/test_tensorflow/test_signal.py

Added kaiser_bessel_derived_window function to tensorflow.frontend.signal.py
Added test_kaiser_bessel_derived_window to test_signal.py
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Aug 25, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@waqaarahmed waqaarahmed changed the title Add kaiser_bessel_derived_window to tensorflow frontend #21877 Add kaiser_bessel_derived_window to tensorflow frontend Aug 25, 2023
@waqaarahmed
Copy link
Contributor Author

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

#21877

@waqaarahmed
Copy link
Contributor Author

@saeedashrraf

@saeedashrraf saeedashrraf linked an issue Sep 13, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@saeedashrraf saeedashrraf changed the title Add kaiser_bessel_derived_window to tensorflow frontend feat(frontend): Added kaiser_bessel_derived_window to tensorflow frontend Sep 13, 2023
@saeedashrraf
Copy link
Contributor

saeedashrraf commented Sep 14, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

@saeedashrraf
Copy link
Contributor

Hello @waqaarahmed , Thank you so much for your contribution. I apologize for the delay. It seems like your PR slipped under the radar 😅. I have linked this to the corresponding issue, but in future you should do this yourself by adding a comment ‘Close #Issue_number’, as explained here”. I have also properly linked your issue with the corresponding todo list item. Please make sure to follow the guide for any future contributions. Thanks again!

@saeedashrraf saeedashrraf merged commit 18cc469 into ivy-llc:main Sep 14, 2023
125 of 139 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
…tend (ivy-llc#22517)

Co-authored-by: Saeed Ashraf <saeedashrraf@gmail.com>
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
…tend (ivy-llc#22517)

Co-authored-by: Saeed Ashraf <saeedashrraf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kaiser_bessel_derived_window
4 participants