-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Take into account frontend supported dtypes in frontend tests #23430
fix: Take into account frontend supported dtypes in frontend tests #23430
Conversation
Thanks for contributing to Ivy! 😊👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
PR Description
There is a problem with function
helpers.get_dtypes
.If
prune_function==True
backend and function are taken into account through_get_supported_devices_dtypes
.If prune_function==False,
_get_type_dict
is used asretrieval_fn
This
retrieval_fn
is used with parameteris_frontend_test=False
which leads to considering only ivy framework dtypes,if
is_frontend_test
wasTrue
, the passed framework would be considered frontend and only that would be taken into account.The
prune_function==True
branch seems to miss the frontend dtypes in case we are in a frontend test.The
prune_function==False
branch, the way it is currently used, seems to miss both frontend and backend dtypes, only ivy dtypes are considered.Trello