-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(paddle): Add broadcast_shape function to Paddle Frontend #23574
feat(paddle): Add broadcast_shape function to Paddle Frontend #23574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
@juliagsy can you have a quick review on the changes made? I am about to be removed from the application process due to slow progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, seems like you have changed docs/demos
which you might have done by mistake. Can you revert that change because we can't merge with that change in place?
I don't think the scripts were working when I created my issue, so it never updated the checklist. The scripts seem to work now. |
@charlie572 thanks for flagging! seems like a glitch in the automation because the linked issue in the todo is the one from @maxxies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey1 The tests are still not passing unfortunately, I've double check the docs and apparently the variable names are diff, they have to be identical to native. Could you please try the below suggested change and continue working on getting the tests to pass? Thanks!
This is the error I still get:
|
…maxxies/ivy into paddle_frontend/broadcast_shape
This |
Could you please try adding |
I think the tuples are handled appropriately but the assertions still fail: ` kwargs["out"] = out ivy_tests/test_ivy/helpers/function_testing.py:830: AssertionError` P.S: It passes for Jax |
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
Hey! Apologies for the delay again! I've been looking into the code and the related function to see where I'm able to help but haven't seen something too off yet. I'll also cc some engineers from the frontends/testing team to see if they have an idea on the issue about gt returning empty list/results. (cc @AnnaTz @sherry30) thanks all! |
Sure, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Just a quick one, could you quickly go into docs/demos
and do git checkout aaef6cb
then cd
back to ivy root and do git add docs/demos
then commit to your own branch? There's a diff showing in docs/demos
in the PR and we don't want to commit any changes in there yet, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
PR Description
Related Issue
Close #23555
Checklist
Socials: