feat(paddle): Add backward method to Paddle Frontend #23661
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
ivy-leaves
added
the
Paddle Frontend
| def backward(self, x): | ||
| return paddle_frontend.Tensor.backward(self.x) |
There was a problem hiding this comment.
you need to implement the backward method as this is an infinite loop
There was a problem hiding this comment.
@MahmoudAshraf97
can you explain more, I don’t get it!. how it's an infinite loop?
There was a problem hiding this comment.
you are calling paddle_frontend.Tensor.backward which inside your function which is also paddle_frontend.Tensor.backward, that means you are calling your function again which calls the same function over and over, an infinite recursion, please read the contribution guide in the docs and check how other functions are implemented in the same file
There was a problem hiding this comment.
@MahmoudAshraf97
I think when calling backward(), paddle_frontend.Tensor.backward() will be invoked one time. I was reviewing this method with someone else and it was ready to be merged but there was a minor change in the name of the test function and I made it, but I made small mistake when committed it, so I opened new PR
There was a problem hiding this comment.
@MahmoudAshraf97
please check this, it's a closed PR for the same issue: #23549
There was a problem hiding this comment.
this code cannot and will not be merged at this stage, as I previously said there's an infinite recursion in your code that need to be solved first and the tests are not passing because of that
There was a problem hiding this comment.
The current test does not actually test the function as it always returns None, please use a test similar to the torch frontend backward method found here:
ivy/ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py::test_torch_tensor_backward
PR Description
Add backward method to Paddle Frontend and tested it
Related Issue
Close #23407
Checklist
Socials: