Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paddle problem with zipping iterables of tensors #27810

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Sam-Armstrong
Copy link
Contributor

Fixes some failing checks on the tracer repo caused by changes in paddle 2.6.0. I've raised an issue on the paddle repo, but this should serve as a temporary solution.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests for gather_nd seem to be failing due to an unsupported dtype issue, could you please add bfloat16 and float16 as the unsupported dtypes for this backend implementation to see if the test passes? Rest of the changes seem good, thanks @Sam-Armstrong 😄

@Sam-Armstrong
Copy link
Contributor Author

Thanks @vedpatwardhan, looks like the test is passing now 😁 I'll go ahead and merge

@Sam-Armstrong Sam-Armstrong merged commit e9267fc into ivy-llc:main Jan 2, 2024
111 of 141 checks passed
@Sam-Armstrong Sam-Armstrong deleted the paddle-zip-fix branch January 2, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants