-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some unit test and CommandSdFileWrite old firmware support. #7
base: master
Are you sure you want to change the base?
Conversation
First great work on getting the tests in place. That's a great step forward for this project. However, I'm confused what you are trying to accomplish with the changes to CRC handling with the SdFileWrite command? You seem to reference a version of Aurora firmware that doesn't exist yet (3.0.0), essentially disabling the CRC check for all existing versions of the firmware which is not what we want. The CRC check is important because file writing can randomly fail and the only way to be sure corrupted data isn't getting saved is to calculate and compare the CRC. Were you having problems with SD file writing? If so, I can help debug to see what the root issue is. |
Off cource, I know CRC check is important. It's very hacky edit for running android app. |
Got it, then we need to get your Aurora updated to the latest version ASAP. Lots of breaking changes happened between 20207 and 20500 and the android app/sdk were not designed with backwards compatibility. Do you have Aurora desktop installed? |
I checked by latest firmware. SdFileWrite command works correct. |
Awesome, glad to hear it. I'll cherry pick everything else. |
Add some unit test. and fix for beta release.