Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some unit test and CommandSdFileWrite old firmware support. #7

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

Amka78
Copy link

@Amka78 Amka78 commented Dec 5, 2018

Add some unit test. and fix for beta release.

@jayalfredprufrock
Copy link
Member

First great work on getting the tests in place. That's a great step forward for this project.

However, I'm confused what you are trying to accomplish with the changes to CRC handling with the SdFileWrite command? You seem to reference a version of Aurora firmware that doesn't exist yet (3.0.0), essentially disabling the CRC check for all existing versions of the firmware which is not what we want.

The CRC check is important because file writing can randomly fail and the only way to be sure corrupted data isn't getting saved is to calculate and compare the CRC. Were you having problems with SD file writing? If so, I can help debug to see what the root issue is.

@Amka78
Copy link
Author

Amka78 commented Dec 11, 2018

Off cource, I know CRC check is important. It's very hacky edit for running android app.
I try to run android app by aurora firmware version 20207, When command SdFileWrite is executed, aurora always returns value 3(Too many command arguments).
so I deleted crc option. I think firmware version 20207 has sd-file-write command bugs.
If you fix firmware bugs, my edit to SdFileWrite don't need at all.

@jayalfredprufrock
Copy link
Member

Got it, then we need to get your Aurora updated to the latest version ASAP. Lots of breaking changes happened between 20207 and 20500 and the android app/sdk were not designed with backwards compatibility. Do you have Aurora desktop installed?

@Amka78
Copy link
Author

Amka78 commented Dec 11, 2018

I checked by latest firmware. SdFileWrite command works correct.
Please exclude my SdFileWrite modify.

@jayalfredprufrock
Copy link
Member

Awesome, glad to hear it. I'll cherry pick everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants