Various fixes after udpate to stc v6 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the `CsOnlinerSourceBuilder` and `CsPlainSourceBuilder` classes, which iterates over the `UsingDirectives` of the `fileSyntax` object and adds each `UsingDirective` to the source code with the appropriate namespace. Additionally, the `class_extended_by_known_type.g.cs` and `file_with_usings.g.cs` files have been updated to include more `using` directives, importing namespaces related to `Simatic.Ax.Stateframework`, `Simatic.Ax.StatePattern`, and various `FileWithUsings` namespaces. 1. The `CsOnlinerSourceBuilder` and `CsPlainSourceBuilder` classes have been updated to include a foreach loop that iterates over the `UsingDirectives` of the `fileSyntax` object. This loop adds each `UsingDirective` to the source code with the appropriate namespace. The `CsOnlinerSourceBuilder` adds the namespace as is, while the `CsPlainSourceBuilder` prepends "Pocos." to the namespace. 2. The `class_extended_by_known_type.g.cs` and `file_with_usings.g.cs` files have been updated to include additional `using` directives. These directives import namespaces related to the `Simatic.Ax.Stateframework`, `Simatic.Ax.StatePattern`, and various `FileWithUsings` namespaces. 3. The `class_extended_by_known_type.g.cs` and `file_with_usings.g.cs` files have also been updated to include additional `using` directives under the `Pocos` namespace. These directives import the same namespaces as above, but under the `Pocos` namespace.
…ods to change the parameter type from `ISyntaxToken` to `PragmaSyntax`. This includes the `AddToDictionaryIfLocalizedString`, `IsPragmaToken`, and `IsStringToken` methods. Additionally, the `IterateSyntaxTreeForPragmas` method has been uncommented and modified, and the `IterateSyntaxTreeForStringLiterals` method has been commented out. The `IsStringToken` method now checks for different `SyntaxKind` types. 1. The `IterateSyntaxTreeForStringLiterals` method has been commented out, disabling its execution. 2. The `IterateSyntaxTreeForPragmas` method has been uncommented and modified. The `token` variable now refers to `pragmaSyntax` and the `IsAttributeNamePragmaToken` method checks the `PragmaContent` of the `token`. 3. The `AddToDictionaryIfLocalizedString` method's parameter type has been changed from `ISyntaxToken` to `PragmaSyntax`. The `TryToGetLocalizedStrings` method now checks the `PragmaContent` of the `token`. 4. The `pos` variable in the `AddToDictionaryIfLocalizedString` method now gets its value from `token.SourceText.GetLineSpan(token.Span).StartLinePosition`. 5. The `IsPragmaToken` and `IsStringToken` methods' parameter type has been changed from `ISyntaxToken` to `PragmaSyntax`. The check for `SyntaxKind.PragmaToken` in `IsPragmaToken` has been commented out. 6. The `IsStringToken` method now checks if the `SyntaxKind` of the `token` is `TypedStringDToken`, `TypedStringSToken`, `UntypedStringDToken`, or `UntypedStringSToken`.
PTKu
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IterateSyntaxTreeForStringLiteralsmethod has been commented out, disabling its execution.IterateSyntaxTreeForPragmasmethod has been uncommented and modified. Thetokenvariable now refers topragmaSyntaxand theIsAttributeNamePragmaTokenmethod checks thePragmaContentof thetoken.AddToDictionaryIfLocalizedStringmethod's parameter type has been changed fromISyntaxTokentoPragmaSyntax. TheTryToGetLocalizedStringsmethod now checks thePragmaContentof thetoken.posvariable in theAddToDictionaryIfLocalizedStringmethod now gets its value fromtoken.SourceText.GetLineSpan(token.Span).StartLinePosition.IsPragmaTokenandIsStringTokenmethods' parameter type has been changed fromISyntaxTokentoPragmaSyntax. The check forSyntaxKind.PragmaTokeninIsPragmaTokenhas been commented out.IsStringTokenmethod now checks if theSyntaxKindof thetokenisTypedStringDToken,TypedStringSToken,UntypedStringDToken, orUntypedStringSToken.CsOnlinerSourceBuilderandCsPlainSourceBuilderclasses have been updated to include a foreach loop that iterates over theUsingDirectivesof thefileSyntaxobject. This loop adds eachUsingDirectiveto the source code with the appropriate namespace. TheCsOnlinerSourceBuilderadds the namespace as is, while theCsPlainSourceBuilderprepends "Pocos." to the namespace.class_extended_by_known_type.g.csandfile_with_usings.g.csfiles have been updated to include additionalusingdirectives. These directives import namespaces related to theSimatic.Ax.Stateframework,Simatic.Ax.StatePattern, and variousFileWithUsingsnamespaces.class_extended_by_known_type.g.csandfile_with_usings.g.csfiles have also been updated to include additionalusingdirectives under thePocosnamespace. These directives import the same namespaces as above, but under thePocosnamespace.