Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] shadows are not updated on onliners change #315

Merged
merged 2 commits into from
Jun 7, 2024
Merged

[BUG] shadows are not updated on onliners change #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
339914c
Create draft PR for #314
IX-BOT Jun 7, 2024
2f5aeea
Shadow base overide onliner property
Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ...azor/src/AXSharp.Presentation.Blazor.Controls/Templates/Base/Shadow/TemplateBaseShadow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,26 @@ namespace AXSharp.Presentation.Blazor.Controls.Templates
{
public partial class TemplateBaseShadow<T> : TemplateBase<T>
{
private OnlinerBase<T> _Onliner;

[Parameter]
public override OnlinerBase<T> Onliner
{
get { return _Onliner; }
set
{
if (_Onliner != value)
{
_Onliner = value;
UpdateShadowValuesOnChange(_Onliner);
}
}
}

protected override Task OnInitializedAsync()
{
UpdateShadowValuesOnChange(Onliner);
// UpdateShadowValuesOnChange(Onliner);
return base.OnInitializedAsync();
}
}
}
}
4 changes: 2 additions & 2 deletions src/AXSharp.blazor/src/AXSharp.Presentation.Blazor.Controls/Templates/TemplateBase.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public IJSRuntime JSRuntime
protected string ToolTipText => Onliner?.HumanReadable;

[Parameter]
public OnlinerBase<T> Onliner { get; set; }
public virtual OnlinerBase<T> Onliner { get; set; }

[Parameter]
public bool IsReadOnly { get; set; }
Expand Down Expand Up @@ -59,7 +59,7 @@ protected T Value
protected override Task OnInitializedAsync()
{
AccessStatus = Onliner.AccessStatus.Failure ? "is-invalid" : "";
ComponentId = Onliner.GetSymbolTail() + "_" + Guid.NewGuid().ToString();
ComponentId = Onliner.Symbol + "_" + Guid.NewGuid().ToString();
return base.OnInitializedAsync();
}
}
Expand Down
Loading