Bump cardano-api, cardano-node #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is broken, I suspect some bounds are wrong on a couple of CHaP packages |
koslambrou
approved these changes
Jan 21, 2025
| @@ -88,7 +87,6 @@ module Convex.CardanoApi.Lenses ( | |||
|
|
|||
| -- * Datums | |||
| _TxOutDatumInline, | |||
| _TxOutDatumInTx, | |||
| _TxOutDatumHash, | |||
There was a problem hiding this comment.
Wasn't just TxOutDatumInTx been renamed to TxOutSupplementalDatum? Then, we
should have a prism for it.
| @@ -416,16 +407,16 @@ _TxInsCollateralIso = iso from to | |||
| [] -> C.TxInsCollateralNone | |||
| xs -> C.TxInsCollateral C.alonzoBasedEra xs | |||
|
|
|||
| _TxMintValue :: (C.IsMaryBasedEra era) => Iso' (TxMintValue BuildTx era) (Value, Map PolicyId (ScriptWitness WitCtxMint era)) | |||
| _TxMintValue :: forall era build. (C.IsMaryBasedEra era) => Iso' (TxMintValue build era) (Map PolicyId [(C.AssetName, Quantity, BuildTxWith build (ScriptWitness WitCtxMint era))]) | |||
There was a problem hiding this comment.
Nice, you managed to generalize the BuildTx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cardano-apito 10.6.0.0Cardano.Api.Extrasthat has thesubstituteExecutionUnitsfunction. We need to keep this until it is exported bycardano-api.