Skip to content

Commit

Permalink
Add tb-nightly requirement for NumPy 2.0 compatibility
Browse files Browse the repository at this point in the history
This is a temporary requirement and should be removed after the tensorboard 2.17.1 release.

References:
- tensorflow/tensorboard#6871
- tensorflow/tensorboard#6874
  • Loading branch information
j3soon committed Aug 13, 2024
1 parent 8a3892e commit 75f384a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/test-with-tox.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,16 @@ jobs:
if: matrix.platform == 'ubuntu-22.04' && matrix.python-version == 3.9
run: |
pip install pandas tensorflow torch tensorboardX pillow matplotlib soundfile pytest pytest-cov
# For NumPy 2.0 compatibility, see: https://github.com/tensorflow/tensorboard/issues/6869
pip install tb-nightly
pytest --doctest-glob="*.rst" --cov=./ --cov-report xml --ignore="tests/test_summary_reader/test_no_tensorflow.py"
- name: Test documentation
if: matrix.platform == 'ubuntu-22.04' && matrix.python-version == 3.9
run: |
sudo apt-get install -y pandoc
pip install -r requirements.txt
# For NumPy 2.0 compatibility, see: https://github.com/tensorflow/tensorboard/issues/6869
pip install tb-nightly
sphinx-build -b html docs docs/_build/html
sphinx-build -b doctest docs docs/_build/doctest
- name: Upload coverage to Codecov
Expand Down
2 changes: 2 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ deps =
commands =
# Test tbparse with reduced feature set (without TensorFlow)
pip install -e .[testing]
# For NumPy 2.0 compatibility, see: https://github.com/tensorflow/tensorboard/issues/6869
pip install tb-nightly
# May need to clean tox cache if the command below failed.
pytest "{toxinidir}/tests/test_summary_reader/test_edge_cases.py" \
"{toxinidir}/tests/test_summary_reader/test_histogram_torch_sample.py" \
Expand Down

0 comments on commit 75f384a

Please sign in to comment.