forked from juju/juju
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix bug where "use --force" prompt is not displayed
For some reason our series selector was not returning an UnsupportedSeries error when it should have been, instead duplicating the text of the error and returning a generic error Return an UnsupportedSeries error when the requested series is not supported by the charm. This can then be detected downstream. However, if the series is not supported by Juju, then we return a normal NotSupported error Remove some duplicated checks. We do not need validate the output of charmSeries, since the series selector guarentees the returned series is supported by juju Drop selecting from charm url as this is a charmstore only feature We also drop charmValidationError in a few places, because all this did was reformat the error from charmSeries. Now I have re-written these error messages, this is not longer required
- Loading branch information
1 parent
3a8220e
commit 49694bf
Showing
7 changed files
with
116 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.