Fix static analysis failures

These were not being picked up by gh actions because we only run
specific tests

core/changestream/terms.go

@@ -1,5 +1,6 @@
 // Copyright 2023 Canonical Ltd.
 // Licensed under the AGPLv3, see LICENCE file for details.
+
 package changestream
 
 var (

domain/controllerconfig/controllerconfig_test.go → domain/controllerconfig/service/controllerconfig_test.go

@@ -1,7 +1,7 @@
 // Copyright 2023 Canonical Ltd.
 // Licensed under the AGPLv3, see LICENCE file for details.
 
-package controllerconfig
+package service
 
 import (
 	ctx "context"
@@ -12,7 +12,6 @@ import (
 
 	jujucontroller "github.com/juju/juju/controller"
 	"github.com/juju/juju/database/testing"
-	domainservice "github.com/juju/juju/domain/controllerconfig/service"
 	domainstate "github.com/juju/juju/domain/controllerconfig/state"
 	schematesting "github.com/juju/juju/domain/schema/testing"
 )
@@ -25,7 +24,7 @@ var _ = gc.Suite(&controllerconfigSuite{})
 
 func (s *controllerconfigSuite) TestControllerConfigRoundTrips(c *gc.C) {
 	st := domainstate.NewState(testing.TxnRunnerFactory(s.TxnRunner()))
-	srv := domainservice.NewService(st, nil)
+	srv := NewService(st, nil)
 
 	cfgIn := jujucontroller.Config{
 		jujucontroller.AuditingEnabled:     true,

tests/suites/static_analysis/doc_go.py

@@ -13,7 +13,7 @@ def check_all(argv):
 	except:
 		print("{0} -i <ignore>".format(argv[0]))
 		sys.exit(2)
-	
+
 	ignores = []
 	for opt, arg in opts:
 		if opt in ("-h", "--help"):
@@ -116,7 +116,7 @@ def package_comment_files(package):
 
 def file_is_generated_mocks(path):
 	with open(path) as f:
-		return f.readline().strip() == "// Code generated by MockGen. DO NOT EDIT."
+		return f.readline().strip().startswith("// Code generated by MockGen.")
 
 if __name__ == '__main__':
 	check_all(sys.argv)