forked from juju/juju
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request juju#16100 from SimonRichardson/inject-ctrl-config…
…-httpserver juju#16100 The following injects the controller config into the http server worker. This worker only uses the controller config in the manifold and any changes to this will cause the http server worker to bounce. This makes it really easy to transfer the manifold over to the new domain package. ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc - [x] Comments saying why design decisions were made - [x] Go unit tests, with comments saying what you're testing ## QA steps ```sh $ juju bootstrap lxd test --build-agent $ juju enable-ha $ juju add-model default $ juju deploy ubuntu -n 3 $ juju controller-config api-port-open-delay=10s ``` Interestingly, setting `juju controller-config api-port-open-delay=10s` doesn't cause the HTTP server to bounce, nor does it get the new value unless it bounces. Maybe we shouldn't allow you to tweak it?
- Loading branch information
Showing
11 changed files
with
1,067 additions
and
920 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.