Fix clientXLogPos handling in pglogrepl_demo #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a bonus, this fixes #20 for me; without bumping the local position on keepalive, a shutting down Postgres just keeps spamming my client with keepalive messages for 10 seconds before hard disconnecting the replication connection. |
|
👍 |
iskakaushik
added a commit
to PeerDB-io/peerdb
that referenced
this pull request
Sep 30, 2023
iskakaushik
added a commit
to PeerDB-io/peerdb
that referenced
this pull request
Sep 30, 2023
This PR is debugging an issue where schema change propagation (#368) don't apply properly when there are parallel transactions happening during an ALTER TABLE statement. Borrowing from jackc/pglogrepl#59 This PR changes the handling of clientXLogPos to match the one from Postgres' own `pg_recvlogical`: - keepalive messages should bump the position too, as they're only sent (from what I can tell) after any xlogdata message; - both the WALStart and the ServerWALEnd in logical xlogdata messages represent the position that should be reported back, and adding the length of the post-decoding data to it is meaningless; - relation messages have a position of zero, and in general we should match the pg_recvlogical behavior of only increasing the local position. --------- Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the handling of
clientXLogPosto match the one from Postgres' ownpg_recvlogical:pg_recvlogicalbehavior of only increasing the local position.